search

sparkfun / SparkFun_u-blox_Cellular_Arduino_Library

Other
0 stars 2 forks source link

Format library #18

Closed sfe-SparkFro closed 11 months ago

sfe-SparkFro commented 11 months ago

Will resolve #9

I have not yet changed any names, just ran the files through a formatter. @gigapod, you mentioned wanting to change some names away from snake case. I'm also not sold on all the names I chose. Do you have any suggestions?

sfe-SparkFro commented 11 months ago

Also, are the file names and directory structure okay? If we're going to change those, would probably be best to do that as part of this PR. And any other house-cleaning things like that, really.

PaulZC commented 11 months ago

u-blox is preferred. ublox 2nd choice. (They prefer without capitalisation....)

sfe-SparkFro commented 11 months ago

@gigapod @PaulZC Changes pushed. Also decided to address #12 in this PR, and I removed a bunch of calls to ubx_cell_calloc_char() in favor of putting arrays on the stack; should help with preventing the heap from getting fragmented, and give a minor performance improvement.

Please take a look and let me know what you think! If all is okay, I'd like to get the first release out this week if possible. There's still a couple open issues, but it should at least be totally useable.

sfe-SparkFro commented 11 months ago

@PaulZC @gigapod Last call for input before I merge this early next week. Thanks!