relax trait requirements for binary operations.

sparsemat / sprs

sparse linear algebra library for rust

Apache License 2.0

411 stars 47 forks source link

relax trait requirements for binary operations. #320

Closed taketo1024 closed 1 year ago

taketo1024 commented 1 year ago

Following #319, I have relaxed the trait requirements for Add, Sub etc for CsVec, so that in particular we can add and subtract vectors with scalar types that does not necessarily implement the num_traits::Num trait.

mulimoen commented 1 year ago

This looks great! Would you mind rebasing on master to include the clippy lint fixes?

taketo1024 commented 1 year ago

Sorry for the late reply.

Would you mind rebasing on master to include the clippy lint fixes?

Sure!

taketo1024 commented 1 year ago

I have rebased relax_trait_restr on master and checked that test runs ok in sprs.

mulimoen commented 1 year ago

Thanks for this PR @taketo1024!