spartan7777 / Individual-Enterprise-Project

Enterprise Java Individual Project
0 stars 0 forks source link

Design/Code Review 1 #2

Open skotcharat opened 4 years ago

skotcharat commented 4 years ago

Design/Code Review 1

Project: The Concept Compendium

Developer: Tosan Ogedengbe

Reviewer: Kotcharat

Item Considerations Comments/Suggestions
Reviewer comments and suggestions go here. Each item should have at least one "kudos" and two suggestions for improvement
Problem Statement 1. Accurately describes project purpose
2. Is professional and free of typos, slang, etc.
3. Fully explains the problem and the solution
4. Is understandable by the average person
1. I used to have some ideas pop up while I am doing something and after that, I forgot because I didn't write it down. This application might be helpful to combine the ideas and help me remember mine thought.
2. Adding Project Technologies on the readme page might be a good idea.
3. Under design, adding link an Application Flow and Database Design.
Design Documentation 1. Navigation/flow through the application is logical and easy to use.
2. The order in which values are displayed is logical and easy to understand/use
3. The order in which the form fields entered is logical and easy to understand/use
4. All data discussed/documented (problem statement, flow, DB design, etc.) is represented on the screens
1. I didn't see the Design Documentation.
2. Is it possible to have trashed when the user accidentally deletes the idea and still has some backup.
3. I don't see the Application Flow design.
Data model/Database 1. Everything on the screens and problem statement/flow is represented in the model
2. There is at least one 1-to-many relationship.
3. The model represents good database design
It doesn't exist yet
Code 1. Proper Maven project structure is used
2. a .gitignore file for IntelliJ Java projects has been implemented
3. There is not any redundant or copy/paste code in the JSPs or classes
4. Classes are appropriately-sized (no monster classes)
Property files are used appropriately: no hard-coded values
5. Logging statements are used rather than System.out.println and printStackTrace.
6. There are appropriate unit tests/code coverages.
It doesn't exist yet