search

spatie / laravel-ray

Debug with Ray to fix problems faster in Laravel apps
https://myray.app
MIT License
291 stars 64 forks source link

Color all high severity log messages red #197

Closed mortenscheel closed 3 years ago

mortenscheel commented 3 years ago

I think it makes sense to add the red color to critical, alert and emergency log messages.

If you like, I could add some tests asserting that the payloads get the expected color.

I'm curious if there's a reason why color values are passed as "magic" strings, and not defined as constants like ColorPayload::GREEN for instance?

freekmurze commented 3 years ago

I'm curious if there's a reason why color values are passed as "magic" strings, and not defined as constants like ColorPayload::GREEN for instance?

just to keep things simple

freekmurze commented 3 years ago

Looks good to me, thanks!