The trace length used by get_traces reflects the actual trace length defined in the modules. get_traces doesn't accept a channel parameter.
Current Behavior
The trace length is fixed to be RANDOMINDICES_LENGTH, see here. According the the API its only used for the tau finder. This could create problems if they were to change that parameter and we didn't realize it.
get_traces pulls traces for an entire module, yet requires that we provide it with a channel number.
Context
Came across this while working on the emulated interface. They could cause confusion for users.
Possible Solution (optional)
For the first part, we should implement the same as what XIA uses in the API's Pixie16ReadSglChanADCTrace function. E.g. Use the TRACE_LENGTH channel parameter.
Second part is simply to remove the channel requirement from the command.
Acceptance Criteria
[ ] get_traces no longer accepts a channel parameter
[ ] get_traces uses the TRACE_LENGTH parameter to determine the size of the trace.
Expected Behavior
The trace length used by
get_tracesreflects the actual trace length defined in the modules.get_tracesdoesn't accept a channel parameter.Current Behavior
The trace length is fixed to be
RANDOMINDICES_LENGTH, see here. According the the API its only used for the tau finder. This could create problems if they were to change that parameter and we didn't realize it.get_tracespulls traces for an entire module, yet requires that we provide it with a channel number.Context
Came across this while working on the emulated interface. They could cause confusion for users.
Possible Solution (optional)
For the first part, we should implement the same as what XIA uses in the API's
Pixie16ReadSglChanADCTracefunction. E.g. Use theTRACE_LENGTHchannel parameter.Second part is simply to remove the channel requirement from the command.
Acceptance Criteria
get_tracesno longer accepts a channel parameterget_tracesuses theTRACE_LENGTHparameter to determine the size of the trace.Bug Report
Steps to Reproduce
./poll2POLL2 $ get_traces 0 0 0Screenshots