Extract Pugixml from source tree - Githubissues

spaulaus / paass

Pixie Acquisition and Analysis Software Suite - maintained by Project Science

GNU General Public License v3.0

0 stars 2 forks source link

Extract Pugixml from source tree #72

Closed spaulaus closed 4 years ago

spaulaus commented 6 years ago

Expected Behavior

Pugixml is installed by user as a dependency.

Current Behavior

We carry around 3rd party source code in the project.

Context

We shouldn't carry around a 3rd party library that's available from standard packages.

Possible Solution (optional)

Add pugixml to the dependency list, and have CMake search for it when building.

Acceptance Criteria

[ ] Pugixml source is no longer in the repository.
[ ] Build fails if pugixml library cannot be found.
[ ] All libraries depending on pugixml build properly.
[ ] All unit-tests depending on pugixml execute properly.

spaulaus commented 4 years ago

This isn't a huge deal.