spawaskar-cora / cora-docs

CoRA Docs
MIT License
36 stars 5 forks source link

Old CIL Sample Letters Box #432

Open mattcgo opened 5 years ago

mattcgo commented 5 years ago

Hello, Thanks for all your work on improving CoRA! Would you be able to add a textbox to input the old CIL DNA sampling format? JPAC used to use letters (CIL Sample A) instead of numbers (CIL Sample 01A) when DNA sampling and we need to use the original sample name when revisiting these old cases. There is currently no space where we can put this in. It would need to be an optional instead of mandatory(*) field.

Screen Shot 2019-04-18 at 3 23 41 PM

Thanks! Matt

clegarde commented 5 years ago

Are you not able to put in just A? You should be able to put in your sample number whether it’s just a letter or number/alphanumeric.

mattcgo commented 5 years ago

Are you not able to put in just A? You should be able to put in your sample number whether it’s just a letter or number/alphanumeric.

We would like to capture both AFDIL's 01A and JPAC's A for the DNA record.

clegarde commented 5 years ago

Ah yes. I know what you’re talking now.

fedamann commented 5 years ago

Thankfully CIL finally dropped the letter designator in favor of the AFDIL number; a nightmare always trying to sync up the two different sample names. I understand why we would keep track of both then, but I do wonder with this new tool if it is still necessary? I ask because I remember tracking both to make sure 01B matched A.1 and both were tied to the same specimen. Now with the relational structure of CoRA the DNA data is always tied to the specimen (with original accession number), and also includes the AFDIL case number and sample number. Is there another reason why you want to track the old CIL sample number that I'm not thinking about?

mattcgo commented 5 years ago

Thankfully CIL finally dropped the letter designator in favor of the AFDIL number; a nightmare always trying to sync up the two different sample names. I understand why we would keep track of both then, but I do wonder with this new tool if it is still necessary? I ask because I remember tracking both to make sure 01B matched A.1 and both were tied to the same specimen. Now with the relational structure of CoRA the DNA data is always tied to the specimen (with original accession number), and also includes the AFDIL case number and sample number. Is there another reason why you want to track the old CIL sample number that I'm not thinking about?

I believe it is good to have a record of the sample letter we originally use, primarily because it is the same number we will use if we resample. If the direction is to move all of our various spreadsheets into CoRA, it would be good to have the option to include the old letter.