search

spaze / phpstan-disallowed-calls

PHPStan rules to detect disallowed method & function calls, constant, namespace, attribute & superglobal usages
MIT License
263 stars 17 forks source link

Do not add ", because reasons" when no message is defined #220

Closed ruudk closed 12 months ago

ruudk commented 1 year ago

I don't like nullability either, but having ", because reasons" being appended by default looks weird and doesn't make sense to me.

Why not leave it out and end the sentence with a period?

-Namespace Doctrine\ORM\Mapping\OneToOne is forbidden, because reasons
+Namespace Doctrine\ORM\Mapping\OneToOne is forbidden.
spaze commented 1 year ago

Yeah, it's weird but it's there to encourage adding your own message because the default one doesn't make much sense 😅 But I'll see, maybe it could be changed, or made configurable.

ruudk commented 11 months ago

Thanks for fixing this. It's a small thing, but it makes it nicer! 💙