search

spc-group / haven

Bluesky tools for beamlines managed by the spectroscopy group
https://haven-spc.readthedocs.io/en/latest/
Other
4 stars 6 forks source link

Robot firefly #221

Closed yannachen closed 5 months ago

yannachen commented 6 months ago

The tests in pull_request are so slow, not finished even after 8 hours.

canismarko commented 6 months ago

@yanna yes there is a problem with the tests where they finish but don't return to the shell so never count as complete. I'm working on it.

Sent from Proton Mail Android

-------- Original Message -------- On 5/29/24 07:27, yannachen wrote:

The tests in pull_request are so slow, not finished even after 8 hours.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

canismarko commented 6 months ago

I cancelled the workflow because it finished the tests but didn't exit the test runner. There was 1 failure, so you could take a look while a fix the test runner (hopefully).

yanna commented 6 months ago

I think you may have the wrong person. I'm not Yanna Chen which I believe is the one you want.

On Wed, May 29, 2024, 9:43 AM Mark Wolfman @.***> wrote:

I cancelled the workflow because it finished the tests but didn't exit the test runner. There was 1 failure, so you could take a look while a fix the test runner (hopefully).

— Reply to this email directly, view it on GitHub https://github.com/spc-group/haven/pull/221#issuecomment-2137847797, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHSPYS2C26WAHYPHFPZ753ZEYAUZAVCNFSM6AAAAABIOCIHKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZXHA2DONZZG4 . You are receiving this because you were mentioned.Message ID: @.***>

canismarko commented 6 months ago

I think you may have the wrong person. I'm not Yanna Chen which I believe is the one you want.

Absolutely right. Sorry about that.