search

spcl / serverless-benchmarks

SeBS: serverless benchmarking suite for automatic performance analysis of FaaS platforms.
https://mcopik.github.io/projects/sebs/
BSD 3-Clause "New" or "Revised" License
149 stars 67 forks source link

Colored output (issues #65) #141

Closed lawrence910426 closed 1 year ago

lawrence910426 commented 1 year ago

Implemented issues #65.

mcopik commented 1 year ago

@lawrence910426 Thank you so much for your contribution! The CLI output looks much better already :-)

I left a few comments on the review - most of them are super simple. I think that if we move the class to LogginBase, this will be a really nice improvement since the entire project will be able to benefit from this improved output.

lawrence910426 commented 1 year ago

I have added a few more commits and fixed the problems mentioned. Thank you @mcopik again for your advising (\^ ^/)

mcopik commented 1 year ago

@lawrence910426 Thanks for your hard work! I think it's almost there :) Please make sure to test to verify that the output is correct, such that we do not get duplicated output :)

Looks really nice on my CLI!

lawrence910426 commented 1 year ago

Hello @mcopik, I have these issues fixed :)

  1. Output typename-uuid for easier debugs.
  2. The static return type is now ColoredWrapper which is a wrapper that imitate a normal logging instance.
  3. Changed the order of properties for mypy to work
  4. Duplicated output on stdout

I have verified the output and it fits our expectations. image

Thank you again for your reviewing! This would surely made CLI more beautiful :)

mcopik commented 1 year ago

@lawrence910426 LGTM, thank you so much! This will make it much easier to catch warnings and errors, particularly in the verbose output mode :)