spdx / spdx-online-tools

Source for the website providing online SPDX tools
https://tools.spdx.org
Apache License 2.0
60 stars 57 forks source link

"Submit license" form apparently only allows 25 characters for suggested short identifier #512

Closed richardfontana closed 10 months ago

richardfontana commented 1 year ago

While one might reasonably think that, in coming up with a short identifier for a license, "25 characters ought to be enough for anybody", the growing complexity of the SPDX license list (including relationships between identifiers) probably makes this limitation inadequate. I am trying to submit a license that is a variant of FSFAP but without the final sentence containing a simple warranty disclaimer. So a natural choice of short identifier is FSFAP-no-warranty-disclaimer but this exceeds the apparent 25 character limit.

goneall commented 1 year ago

@richardfontana - should we have a limit on the length of the ID's? If so, what would be reasonable?

richardfontana commented 1 year ago

@goneall my thought was perhaps double the existing limit?

richardfontana commented 1 year ago

I was again hit by this limitation when attempting to submit a new license. I wanted to suggest the identifier BSD-3-Clause-Intel-variant but the form would only give space for BSD-3-Clause-Intel-varian.

goneall commented 1 year ago

Due to the demands from the SPDX 3.0 release, I probably won't get to a fix in the near term. Hoping to find a volunteer in the community to provide a pull request.

Ash-KODES commented 12 months ago

Can I work on this ? @goneall

goneall commented 12 months ago

@Ash-KODES - that would be great - thanks!

goneall commented 11 months ago

@Ash-KODES It would be great to get in a pull request for this soon - I'm planning on doing a release this week.

Let me know if you're able to take this on - otherwise I'll take a stab at it.

cc: @rtgdk

Ash-KODES commented 11 months ago

I will make a PR for this today

goneall commented 11 months ago

@Ash-KODES - Just checking in on the PR - let me know if you think you'll be able to get the PR done in the next day or so

BassCoder2808 commented 10 months ago

Hi @goneall, If the issue is still open I would like to contribute to it, I will create the PR for the same and you can review it and we can move forward with it

BassCoder2808 commented 10 months ago

We can close this issue now @goneall