Closed RachithP closed 6 months ago
This whole PR is looking fantastic. I want to take another look before approving but we're definitely on the right track.
if value == None
-> if value is None
Env
methods shouldn't be static. They take as input an Instance
, so they need some state to operate, and the state they need is cached in an Env
object. What is being gained by making these methods static? Wouldn't it be simpler to call my_env.tick()
compared to Env.tick(my_env.instance)
?#include "SpCore/Whatever.h"
for our own headers. SpEngine
currently uses <>
for our headers in several places.
SimulationController
->SpEngine
SimulationController
code underSpEngine/Legacy
EngineService
,GameWorldService
,LegacyService
,WorkQueue
inSpEngine
plugin.clean_project_dir.py
to provide a script for cleaning temporary project files.