specify / specify7

Specify 7
https://www.specifysoftware.org/products/specify-7/
GNU General Public License v2.0
63 stars 36 forks source link

Out of Range Value allowed to Save causes error & Save Block Warning message unclear #5284

Open pashiav opened 3 days ago

pashiav commented 3 days ago

Describe the bug Inputting a number larger than "999999999" (10,000,000,000 and up) into the:startperiod, endperiod, startuncertainty, enduncertainty fields of a Chronostratigraphy record, then saving, causes an error.

While on the Chronostratigraphy Tree trying to create a new record, I had a Save Block warning message appear stating "Value must be a number" when I had 9000940390394039000 as my input, even though it is a number. Can not be reproduced consistently. Screen Shot 2024-09-23 at 1 02 38 PM

To Reproduce

  1. Go to any Chronostratigraphy record (https://kuvertpaleo20240606-production.test.specifysystems.org/specify/view/geologictimeperiod/185/)
  2. Change the field of either startperiod, endperiod, startuncertainty, enduncertainty to a value > 999999999 (10000000000)
  3. Save
  4. See error or Save blocker message

Expected behavior Save should be blocked and a warning message stating the input is out of range should be displayed.

Evidence

https://github.com/user-attachments/assets/ff2234fb-e664-4981-a0b3-bd40a8ab7a2a

Crash Report Specify 7 Crash Report - 2024-09-23T18_14_25.318Z.txt

Additional context Talked to @CarolineDenis and the range set as the max for these fields could be either something the user added in schema config or a value we have in our code.

grantfitzsimmons commented 15 hours ago

This is happening in both v7.9.6.2 and production

image