search

spectralpython / spectral

Python module for hyperspectral image processing
MIT License
571 stars 139 forks source link

Error while performing MNF. #82

Closed BlcaKHat closed 5 years ago

BlcaKHat commented 6 years ago

I am trying for MNF as suggested in the example. but it need two params (only one is given.)

mnf

tboggs commented 6 years ago

That is a typo in the web site documentation. The first argument to denoise should be the data to be denoised. The doc string for the denoise method describes the arguments correctly. The same is true for the reduce method.

BlcaKHat commented 6 years ago

I was checking the result with ENVI result (MNF Rotation -> forward rotation ->Estimate Noise Statistics from data .) The results are little different. I don't no if they are same process. Suggest me something.

tboggs commented 6 years ago

It isn't surprising for results to be a little different since they depend on the particular way that noise statistics are estimated.

donm commented 6 years ago

Keep in mind, it can't be assumed with 100% certainty that all ENVI algorithms are optimal, standard, or even correct. For example, the ENVI implementation of ACE was incorrect until version 5.2.

Also, not having the ENVI source code, there's little that @tboggs or anyone can do to answer questions about differences in results. All you can do is read the implementation of the algorithm in SPy and verify that it's correct (or that it needs to fixed). I'm sure that Thomas would always be happy to have more eyes reviewing the source code.

BlcaKHat commented 6 years ago

thanx @tboggs . I will be in touch.