search

speedb-io / speedb

A RocksDB compliant high performance scalable embedded key-value store
https://www.speedb.io/
Apache License 2.0
882 stars 65 forks source link

IsEmpty() checks were missing before some SwitchMemtable() invocation… #808

Open pranavshenoy opened 7 months ago

pranavshenoy commented 7 months ago

Bug: https://github.com/facebook/rocksdb/issues/12179

There was one instance where the IsEmpty() check was missing:

rocksdb/db/db_impl/db_impl_write.cc

Line 1706 in 21d5a8f

status = SwitchMemtable(cfd, write_context); Having one check inside SwitchMemTable() will ensure there won't be misses in the future.

CLAassistant commented 6 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

PRANAV SHENOY seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.