search

speedb-io / speedb

A RocksDB compliant high performance scalable embedded key-value store
https://www.speedb.io/
Apache License 2.0
919 stars 72 forks source link

zlib: Update ci and Makefile using a different link #820

Closed Yuval-Ariel closed 10 months ago

ofriedma commented 10 months ago

@Yuval-Ariel @udi-speedb maybe we should use this link: https://github.com/madler/zlib/releases/download/v1.3.1/zlib131.zip

Yuval-Ariel commented 10 months ago

should we also keep the version at 1.3 in the makefile?

udi-speedb commented 10 months ago

@maxb-io, @speedbmike - We are changing the CI here and leaving the Makefile with the existing URL-s. Seems strange to me. Will this work for somebody building speedb on a clean environment without using our CI?

udi-speedb commented 10 months ago

@Yuval-Ariel - What about CMakeLists.txt / cmake?

Yuval-Ariel commented 10 months ago

@Yuval-Ariel - What about CMakeLists.txt / cmake?

@udi-speedb, No idea