search

spesmilo / electrum

Electrum Bitcoin Wallet
https://electrum.org
MIT License
7.56k stars 3.11k forks source link

Python3 support #1075

Closed asfin closed 7 years ago

asfin commented 9 years ago

Will electrum migrate/support Python3? What stops this process? If I provide pull request on this issue, is there any chance that it will be accepted?

I've applied 2to3 script + few patches in code, so i can import and use libs, and qtgui can start and looks like it alive and responsible(i don't know is it fully functional or not).

Sorry if this is a dublicate, but i can't find any information about python3 support in electrum.

ecdsa commented 7 years ago

note: the python3 branch was rebased today

ecdsa commented 7 years ago

@asfin I am rebasing this now, targetting next major release can you tell me how you generated the protobuf _pb2 file? there are more protobuf files that need to be converted in the hardware wallet libs

asfin commented 7 years ago

@ecdsa i've downloaded last protobuf version with py3 support, build it, and generated with it.

ecdsa commented 7 years ago

this was finallly merged into master. yay!