spesmilo / electrum

Electrum Bitcoin Wallet
https://electrum.org
MIT License
7.53k stars 3.11k forks source link

[Android] Add to F-Droid #1700

Closed dllud closed 1 month ago

dllud commented 8 years ago

Please add the new Electrum for Android into F-Droid repository. You should also provide a direct download link for the apk on your download server (download.electrum.org).

Many of us don't wanna use GApps on our devices.

ghost commented 7 months ago

@SomberNight @ecdsa @accumulator @bauerj Some clarity on this matter would be highly appreciated! This issue has been open for just over 8 years now.

SomberNight commented 7 months ago

I think my comments have been clear over the years.

See https://github.com/spesmilo/electrum/issues/1700#issuecomment-887392215 :

if someone steps up and writes an initial F-Droid build script that can reproduce the apk we published on the website, we would use it and start publishing on F-Droid.

Please take the time and write that initial fdroid build script. I will try my best to maintain it and keep pushing releases to the official F-Droid repo after that.

there are many instances that come to mind of other apps in the crypto space claiming their code to be "open source" but when one tries to build it becomes readily apparent that there are either closed/proprietary libraries involved without which this is not possible. Or that their published APKs contain some functionality not included in any of the published code.

I am somewhat insulted by the insinuation that Electrum is not fully open source. If you didn't even take the time to build an apk using our ~one-liner build instructions, which build reproducible binaries(!), I guess it is pointless to ask you to write that fdroid build script.

ghost commented 7 months ago

@SomberNight Thank you for the response! Unfortunately, you are quite correct that it is pointless to ask me to help with this project 😓

I'm not sure what exactly in my previous post insinuated any allegation of Electrum not being fully open source. It is pertinent to consider the cryptocurrency space within which Electrum operates, which is full of inadequately-developed solutions, and some disreputable entities. As I pointed out before, I do consider Electrum to be both well-vetted and reputable. It's an excellent sign that your product is already included with other open source products as well as repositories.

Hope we are able to find someone soon who can help with the work of integrating with the Fdroid build system! Hope the new qml GUI will not be a stumbling block @IzzySoft Do you have any advice here?

ghost commented 6 months ago

@SomberNight Is it possible to build without docker? https://gitlab.com/fdroid/rfp/-/issues/188

ghost commented 6 months ago

@SomberNight ^

accumulator commented 6 months ago

As this is getting a bit annoying, I'm locking this issue for now. Anyone is free to contribute the necessary bits for F-droid publishing in a PR.

Until then, there's no use asking for status updates, as we haven't prioritized this, and probably won't for the foreseeable future.

accumulator commented 1 month ago

see #9211

SomberNight commented 1 month ago

note: lots of related comments in https://github.com/spesmilo/electrum/issues/9210 and https://github.com/spesmilo/electrum/issues/9215 and also https://gitlab.com/fdroid/fdroiddata/-/merge_requests/15858

SomberNight commented 1 month ago

Thanks to the significant contributions of @thecockatiel, there is now a release of Electrum in the official F-Droid repo. And it is reproducibly built by the F-Droid buildserver, hence signed by the same key, so it cross-compatible with the website and google play apks!

@thecockatiel Thank you for the work.