search

spesmilo / electrum

Electrum Bitcoin Wallet
https://electrum.org
MIT License
7.32k stars 3.05k forks source link

Android Offline Signing via QR code #8561

Open Scollop355 opened 1 year ago

Scollop355 commented 1 year ago

Hi, I can't find my old posts to update you on this problem so had to open a new post.

Electrum on Android.

Single signature wallets signing off line via qr code working on 4.3.4 but not functioning on versions 4.4.4 and 4.4.5 give following error.

"Warning: Some data (prev txs / "full utxos") was left out of the QR code as it would not fit.  This might cause issues if signing offline.  As a workaround, try exporting the tx as file or text instead."

I have several wallets which all worked for offline signing without the error until the new GUI versions of Electrum were released.

SomberNight commented 1 year ago

please don't open duplicate issues. (https://github.com/spesmilo/electrum/issues/8538)

It is not an error but a warning. IIRC the only thing changed between e.g. 4.3.4 and 4.4.5 in this respect is that we now show the warning. The underlying logic is still the same, and the text of the warning also applied to older versions, it was just not shown.

Have you actually tested offline signing? If it worked on older versions, it should still work.

Scollop355 commented 1 year ago

Yes, I did test 4.4.5 with offline signing and it did work despite the warning, but I only did that because there was only a small amount of funds on the wallet.

Thanks for the clarification that this issue was in older versions but not displayed. Now that I know this, I will avoid offline signing via QR code and stick to the copy and paste method to be safe.

On Tue, 1 Aug 2023, 16:49 ghost43, @.***> wrote:

please don't open duplicate issues. (#8538 https://github.com/spesmilo/electrum/issues/8538)

It is not an error but a warning. IIRC the only thing changed between e.g. 4.3.4 and 4.4.5 in this respect is that we now show the warning. The underlying logic is still the same, and the text of the warning also applied to older versions, it was just not shown.

Have you actually tested offline signing? If it worked on older versions, it should still work.

— Reply to this email directly, view it on GitHub https://github.com/spesmilo/electrum/issues/8561#issuecomment-1660599182, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHOHWVYX6QKHA3MK3IBARHLXTEQQJANCNFSM6AAAAAA276PLAE . You are receiving this because you authored the thread.Message ID: @.***>

ecdsa commented 1 year ago

@SomberNight This message might be doing more harm than good, scaring off users. Would it make sense to remove it from the QR code window, and to display it only at signing time, if the signing device actually requires the previous utxos in order to sign?

Scollop355 commented 1 year ago

Sorry. I don't understand what you mean when you state "Would it make sense to remove it from the QR code window, and to display it only at signing time, if the signing device actually requires the previous utxos in order to sign?"

On Wed, 2 Aug 2023, 11:00 ThomasV, @.***> wrote:

@SomberNight https://github.com/SomberNight This message might be doing more harm than good, scaring off users. Would it make sense to remove it from the QR code window, and to display it only at signing time, if the signing device actually requires the previous utxos in order to sign?

— Reply to this email directly, view it on GitHub https://github.com/spesmilo/electrum/issues/8561#issuecomment-1661917815, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHOHWVZ4TNXJ3ZC2O47RGR3XTIQNDANCNFSM6AAAAAA276PLAE . You are receiving this because you authored the thread.Message ID: @.***>