search

sphinx-contrib / sphinxcontrib-towncrier

An RST directive for injecting a Towncrier-generated changelog draft containing fragments for the unreleased (next) project version. Demo: https://ansible-pylibssh.rtfd.io/changelog. Docs: https://sphinxcontrib-towncrier.rtfd.io
https://pypi.org/p/sphinxcontrib-towncrier
BSD 3-Clause "New" or "Revised" License
18 stars 18 forks source link

Add Github Actions and tox with docs and pre-commit #12

Closed gaborbernat closed 4 years ago

gaborbernat commented 4 years ago

A follow-up PR would be to add actual tests... Did some of this already in the past here https://github.com/gaborbernat/sphinx-autodoc-typehints/blob/master/tests/test_project_format.py#L20

Here's the run show would this be accepted it would actually pass https://github.com/gaborbernat/sphinxcontrib-towncrier/actions/runs/197400588

webknjaz commented 4 years ago

Ouch... This was supposed to be a learning experience for @slsh1o

gaborbernat commented 4 years ago

oh ok you want to reject the PR then?

gaborbernat commented 4 years ago

I'll retract back into my shell, and ignore this library then.

webknjaz commented 4 years ago

@gaborbernat thanks! I'll ping you once it's ready to be looked at.

gaborbernat commented 4 years ago

Please don't, I'm no longer interested in the project.

thanks

webknjaz commented 4 years ago

Sorry

gaborbernat commented 4 years ago

No worries ☺️