spicetify / marketplace

Download extensions and themes directly from Spicetify
MIT License
1.03k stars 174 forks source link

Improve "Last updated" #779

Open Theblockbuster1 opened 3 months ago

Theblockbuster1 commented 3 months ago

📝 Provide a description of the new feature

Instead of checking for the last commit in the repo, perhaps the "last updated" date could be found from checking for the last commit made to the specific extension file.

➕ Additional Information

Would be more accurate, as right now updating anything in the repository displays that an individual extension was updated.

sanoojes commented 1 month ago

yes it is it just looks for the repo last update

Theblockbuster1 commented 1 month ago

@sanoojes I'm trying to say that it would be nice if multiple extensions in one repo wouldn't be grouped together, for when only one (or none) extension may have been recently updated.

Marketplace: image Actual commit dates: image

sanoojes commented 1 month ago

In Spicetify v3, it will be good to add a feature to check the last commit date of a specific folder of extenstion in a GitHub repository.

it can be implemented like this Fetch Data: Use GitHub API:

   https://api.github.com/repos/[username]/[reponame]/commits?path=[foldername]

Extract Date: Get commit.committer.date from the latest commit.

but we need to figure out how to get the folder name

downsides - it will result in too many request to the api or spicetify should request the devs to split them to diff repos which is also not good

NB: idk much about it its just suggestion