search

spiffe / helm-charts

Helm charts for SPIRE and other SPIFFE components.
Apache License 2.0
20 stars 22 forks source link

Revise the design of testing the helm-chart #232

Open marcofranssen opened 1 year ago

marcofranssen commented 1 year ago

We might want to consider revising the designed setup of testing the helm-chart.

It seems chart-testing allows to define a ci folder within the chart to define the value overrides when testing a chart.

https://github.com/helm/chart-testing/blob/main/pkg/chart/test_charts/must-pass-upgrade-install/ci/test-values.yaml

Maybe we should reconsider our strategy to simplify the testing setup.

kfox1111 commented 1 year ago

+1

But, did they ever get a fix for https://github.com/helm/chart-testing/issues/211 ? When I originally proposed pre-install.sh, I couldn't find a way to do that without the hack that issue 211 does to workaround the issue.