search

spiffe / helm-charts

Helm charts for SPIRE and other SPIFFE components.
Apache License 2.0
20 stars 22 forks source link

Fix initContainers spire-server statefulset #458

Closed marcofranssen closed 1 year ago

marcofranssen commented 1 year ago

To allow for inplace upgrades of spire-server statefulset we are not allowed to make changes to all fields of the statefulset spec.

When bumping from 0.8.1 to the latest version the initContainers: field is added in the spec and therefore does not allow for updating the statefulset.

This fix prevents the empty initContainers block when bumping from a previous chart version.

kfox1111 commented 1 year ago

We probably need at least one upgrade test.

I just tested it and adding an init container works fine for a statefulset. So, I don't think this is needed?

marcofranssen commented 1 year ago

We probably need at least one upgrade test.

I just tested it and adding an init container works fine for a statefulset. So, I don't think this is needed?

In my case I don't have initcontainers, but on upgrade it still renders the initContainers without a value.

Try 'helm template'

Or

'helm diff upgrade'