This doesn't seem to be fixed, even with the latest commit as of Aug 18, 2020. When TEventMM = mmManual or mmManualAndFreeMainEvent, LEvent is NEVER properly free-ed, and will result in memory leak!

spinettaro / delphi-event-bus

Delphi Event Bus (for short DEB) is an Event Bus framework for Delphi

Apache License 2.0

466 stars 110 forks source link

This doesn't seem to be fixed, even with the latest commit as of Aug 18, 2020. When TEventMM = mmManual or mmManualAndFreeMainEvent, LEvent is NEVER properly free-ed, and will result in memory leak! #30

Closed wxinix closed 4 years ago

wxinix commented 4 years ago

This doesn't seem to be fixed, even with the latest commit as of Aug 18, 2020. When TEventMM = mmManual or mmManualAndFreeMainEvent, LEvent is NEVER properly free-ed, and will result in memory leak!

The test cases do not cover mmManual and mmManualAndFreeMainEvent

Originally posted by @wxinix in https://github.com/spinettaro/delphi-event-bus/issues/10#issuecomment-675817620

wxinix commented 4 years ago

It seems a non-issue, after looking into the code again:

mmManual the Event object needs to be free-ed by its creator in the user code, AS WELL AS in the subscription handler by the user
mmManualAndFreeMainEvent the Event object needs to be free-ed inside the subscription handler
mmAutomatic the user code doesn't need to do anything.

I found this has somewhat clarified in this thread: https://github.com/spinettaro/delphi-event-bus/issues/27