search

spiroid / pelican-hpstr

Port of jekyll-hpstr-theme to pelican
GNU General Public License v2.0
4 stars 3 forks source link

Connecting with disqus comments #12

Open whiletruelearn opened 9 years ago

whiletruelearn commented 9 years ago

I had set up disqus in peliconf.py by entering the details

DISQUS_SITENAME = '' DISQUS_SECRET_KEY = '' DISQUS_PUBLIC_KEY = ''

Also i had the template code mentioned in disqus plugin page in the article.html file. But disqus didn't load while running in local.

Disqus template code was taken from - https://github.com/getpelican/pelican-plugins/tree/master/disqus_static

I put it in this portion of article.html 

{# TODO -- comments {% if site.disqus_shortname and page.comments %}<section id="disqus_thread"></section><!-- /#disqus_thread -->

Could you please look into this

whiletruelearn commented 9 years ago

Hi I had found a way to fix this by adding disqus to the current them. If you could add me as a collaborator, i can push it to a branch called 'disqus'

Cheers

spiroid commented 9 years ago

hi,

@kskrishnasangeeth: sorry for that very late reply. I was very busy lately and didn't take the time to take care of issues on github.

Many thanks for your message and your time.

i'm thinking of adding comments support to the theme, not only for discus, but also for other alternatives. i don't really feel confident for adding people direcly as contributors on my github repositories. Not because i don't trust people but mostly because i like to do some code review and learn in reading other people's code.

That's why I prefer the fork and pull request approach :)

Please fork that repository, add a disqus branch on your fork and open a pull request with the feature you want to see integrated.

whiletruelearn commented 9 years ago

Thank you @spiroid . I will send you a PR shortly.