search

spite / THREE.MeshLine

Mesh replacement for THREE.Line
MIT License
2.16k stars 380 forks source link

Merge with three.meshline #102

Closed ryanking1809 closed 4 years ago

ryanking1809 commented 4 years ago

Can confirm all demos work exactly the same as before. Renamed files to match the existing file structure.

Jeremboo commented 4 years ago

Amazing man! Give me some time to take a look of it too! Some demos don't cover some features

lancelet commented 4 years ago

AFAICT, this also contains the changes from PR #73, right? Seems to need a rebase though.

ryanking1809 commented 4 years ago

AFAICT, this also contains the changes from PR #73, right? Seems to need a rebase though.

Oh yes, that's right. That will break some things, however, I do believe @axion014 modifications here are more correct than the existing implementation.

Can fix up the readme in the future as well :)

dskeithbuck commented 4 years ago

Any updates on this? Hoping to use @ryanking1809's changes but would rather pull from this repo. Thanks!

lancelet commented 4 years ago

I'd really like to see things consolidated too. I've switched to @ryanking1809's version for the time being, but I hope there will be a central place for future development. It's really up to the maintainers of this repository to decide though (if / when they have time).

Hopefully the missing examples / test cases that are mentioned above can be enumerated so that those of us who are cheering from the sidelines can help provide them later.

trusktr commented 4 years ago

@Jeremboo Can you please make the demos that show the features that you said aren't currently shown, so we can verify them? That would be extremely great.

ryanking1809 commented 4 years ago

Thanks @Jeremboo , should be able to review over the weekend!

ryanking1809 commented 4 years ago

All good, let's call it done! Thanks @Jeremboo !

Jeremboo commented 4 years ago

It's officially merged! Thanks a lot for you wait!

I hope we are not going to have issues haha

ryanking1809 commented 4 years ago

Thanks Jeremeboo! I've been exploring some projects on codesandbox, swapping 1.2.0 for 1.3.0 and haven't hit any issues. Seems solid 💪

I might archive my branch in the next few days and direct people here!

ryanking1809 commented 4 years ago

This merge should resolve the following issues:

https://github.com/spite/THREE.MeshLine/issues/99 https://github.com/spite/THREE.MeshLine/issues/85 https://github.com/spite/THREE.MeshLine/issues/84 https://github.com/spite/THREE.MeshLine/issues/78 https://github.com/spite/THREE.MeshLine/issues/64 https://github.com/spite/THREE.MeshLine/issues/60 https://github.com/spite/THREE.MeshLine/issues/52 https://github.com/spite/THREE.MeshLine/issues/51 https://github.com/spite/THREE.MeshLine/issues/2

geordie2020 commented 2 years ago

How exactly is #60 resolved by this? I'm still looking for a way to update the geometry without passing all points on every frame.