search

splitbrain / dokuwiki-plugin-sync

Sync DokuWiki namespaces with a remote wiki on request
http://www.dokuwiki.org/plugin:sync
17 stars 17 forks source link

remove some warnings observed with PHP 8.1 #65

Closed gturri closed 1 year ago

gturri commented 2 years ago

This fixes concerns reported by #63 that I've also observed on my side.

(Note that this does not fix every warnings, but most of those already. I've also observed some near line 560 because when the key 'local' is not defined. I'm not really sure how this corner case should be fixed. Anyway, I guess the leftover could probably be tackled by future PR, given that this one already improves a bit the situation)

dregad commented 1 year ago

It would be much appreciated if this PR could be merged and a new version of the plugin released. Thank you !

gturri commented 1 year ago

hi @splitbrain ,

Though this PR is 9 months old, I would still be thrilled to get some feedback on it :) Does it looks good to you? Do you have concerns with it? (or perhaps you'd rather I merge this repo altogether and go with a fork if you don't have time to maintain it anymore?)

splitbrain commented 1 year ago

Well, TBH this is not the right approach. Request variables should be accessed via $INPUT and that would fix a lot of problems already. However this is all moot considering that this plugin needs more cleanup anyway and that I had started the cleanup a long while ago in the refactor branch. Unfortunately I got distracted and never finished it...

gturri commented 1 year ago

Thanks for this feedback 👍 I'll hence close this PR.