splitio / ios-client

iOS SDK client for Split Software
https://split.io
Other
11 stars 18 forks source link

make `toString()` on `SplitEvent` public #515

Closed ohwhen closed 3 months ago

ohwhen commented 5 months ago

iOS SDK

What did you accomplish?

Tiny PR to make the toString() method public.

ohwhen commented 4 months ago

@javrudsky can we land this pls?

ohwhen commented 4 months ago

@javrudsky thanks for the stamp, looks like it needs approval to run the required checks. I've also rebased my changes onto the development branch instead.

ohwhen commented 4 months ago

@javrudsky I can't merge this because the workflows cannot run without approval

javrudsky commented 4 months ago

Hi @ohwhen , thank you for your contribution. I'll merge the changes as soon the checks run.

ohwhen commented 4 months ago

Thanks @javrudsky looks like there are some flaky tests...let me know if I can help here, happy to chime in.

javrudsky commented 4 months ago

Hi @ohwhen! Yes, after updating GHA vm to Xcode 15, we've encountered some issues. I can offer two options:

  1. You can merge (or rebase) the development branch into your branch.
  2. I can create a new, small PR from our branch.

Please let me know which option you prefer.

ohwhen commented 4 months ago
  1. You can merge (or rebase) the development branch into your branch.
  2. I can create a new, small PR from our branch.

Please let me know which option you prefer.

@javrudsky no worries, just rebased development onto my branch, hopefully this should do the trick 🤞

ohwhen commented 4 months ago

@javrudsky not sure why these tests keep failing, I'm happy to rebase or fix my PR but kinda feels this small of a change can just be force-merged without harm? ☺️

ohwhen commented 4 months ago

@javrudsky anything I can do to help land this super tiny change? ☺️

ohwhen commented 4 months ago

@javrudsky just rebased latest development onto my branch so hopefully this should be ready to be merged now 🤞

javrudsky commented 3 months ago

Thank you for your contribution @ohwhen!!