Closed ohwhen closed 3 months ago
@javrudsky can we land this pls?
@javrudsky thanks for the stamp, looks like it needs approval to run the required checks. I've also rebased my changes onto the development branch instead.
@javrudsky I can't merge this because the workflows cannot run without approval
Hi @ohwhen , thank you for your contribution. I'll merge the changes as soon the checks run.
Thanks @javrudsky looks like there are some flaky tests...let me know if I can help here, happy to chime in.
Hi @ohwhen! Yes, after updating GHA vm to Xcode 15, we've encountered some issues. I can offer two options:
Please let me know which option you prefer.
- You can merge (or rebase) the development branch into your branch.
- I can create a new, small PR from our branch.
Please let me know which option you prefer.
@javrudsky no worries, just rebased development
onto my branch, hopefully this should do the trick 🤞
@javrudsky not sure why these tests keep failing, I'm happy to rebase or fix my PR but kinda feels this small of a change can just be force-merged without harm? ☺️
@javrudsky anything I can do to help land this super tiny change? ☺️
@javrudsky just rebased latest development onto my branch so hopefully this should be ready to be merged now 🤞
Thank you for your contribution @ohwhen!!
iOS SDK
What did you accomplish?
Tiny PR to make the
toString()
method public.