search

splitio / php-client

PHP SDK client for Split Software
https://split.io
Other
16 stars 12 forks source link

Error while extracting composer package in 7.2.0 | duplicate class in two different files #225

Closed mtreuberg closed 6 months ago

mtreuberg commented 6 months ago

When installing the composer package in version 7.2.0 the following error occurs on macOS:

  - Installing splitsoftware/split-sdk-php (7.2.0): Extracting archive
    Failed to extract splitsoftware/split-sdk-php: (1) '/usr/bin/unzip' -qq '/Users/.../vendor/composer/tmp-3adceb1e2ad196f58b2ac42cebdedab9.zip' -d '/Users/.../vendor/composer/6e494f8f'

replace /Users/.../vendor/composer/6e494f8f/splitio-php-client-4d0aef5/src/SplitIO/Sdk/Validator/flagSetsValidator.php? [y]es, [n]o, [A]ll, [N]one, [r]ename:  NULL
(EOF or read error, treating as "[N]one" ...)

    The archive may contain identical file names with different capitalization (which fails on case insensitive filesystems)
    Unzip with unzip command failed, falling back to ZipArchive class
    Skipped installation of bin bin/splitio for package splitsoftware/split-sdk-php: name conflicts with an existing file

It seems that the same class exists in two files in https://github.com/splitio/php-client/tree/master/src/SplitIO/Sdk/Validator, one with an upper case first char and another with a lower case first char:

I guess that https://github.com/splitio/php-client/blob/master/src/SplitIO/Sdk/Validator/flagSetsValidator.php could simply be deleted, as the content of the two files is identical.

agustinona commented 6 months ago

@mtreuberg thanks for reporting this and apologies for the inconvenience. Our team is looking into it.

agustinona commented 6 months ago

@mtreuberg this issue has been fixed in version 7.2.1