search

splitwise / super_diff

A more helpful way to view differences between complex data structures in RSpec.
https://splitwise.github.io/super_diff/
MIT License
991 stars 54 forks source link

Revert nvmrc to a widely compatible string #249

Closed jas14 closed 6 months ago

jas14 commented 6 months ago

Hello from Railsconf! 👋 This closes #248 by updating the specifier in .nvmrc to one compatible with nodenv and asdf, neither of which (unfortunately) support the lts/* specifier. (Neither of these tools will read .nvmrc anyway, I'm assuming an entry point of bin/setup.)

mcmire commented 6 months ago

Hello!

There is a way to make asdf read .nvmrc like NVM would (and I admit I have asdf configured to do this). But I agree with you that right now, this file won't work out of the box, whether you're using asdf, NVM or nodenv.

I am okay with accepting this PR to make the NVM case work at least. That said, you highlight a valid point in your original issue with bin/setup, which is that it claims to support all of these Node managers, and yet this project only has a configuration file for NVM. I don't really want to support every single way of installing Node out there, so maybe it's worth simplifying the setup script (or if I can work out a way to read a VSCode dev container config in Vim, then I can just add support for dev containers). But I guess that's something for another PR :)

jas14 commented 6 months ago

Agreed, it's almost as complicated supporting the various version managers as it is managing different Node versions! 😛 Thank you!