search

splitwise / super_diff

A more helpful way to view differences between complex data structures in RSpec.
https://splitwise.github.io/super_diff/
MIT License
991 stars 54 forks source link

Improve inspection of Module #263

Closed phorsuedzie closed 1 month ago

phorsuedzie commented 2 months ago

A module's inspection (used e.g. generate a description of an RSpec example) has been improved to now include the module's name, which identifies the module better than the previous string.

Old: #<Module:0x0000000107f7a0a0> New (e.g.): SuperDiff::Test.

The improvement declares a Module a Primitive (which is what has been used for a Class already).

Closes #255.

FYI: Most of the time was spent to get the specs run locally. See https://github.com/splitwise/super_diff/commit/24b8183acf64ca4f4559286bdb6ac4750e43716f.

jas14 commented 1 month ago

Thanks for the PR, @phorsuedzie ! I'll take a look soon. I want to address your setup comments – I think we could improve the linter. I'm considering switching back to Rubocop or another Ruby-based linter to keep things in the same ecosystem.