search

splix / grails-spring-security-facebook

Facebook Authentication plugin for Grails
http://splix.github.io/grails-spring-security-facebook/index.html
Other
39 stars 35 forks source link

LinkGenerator package changed #94

Open lojzatran opened 7 years ago

lojzatran commented 7 years ago

The package for class LinkGenerator has changed with recent versions of Grails. This plugin does not work with Grails 3.2.0 anymore.

It has been moved from org.codehaus.groovy.grails.web.mapping.LinkGenerator to grails.web.mapping.LinkGenerator.

This line is causing the problem: https://github.com/splix/grails-spring-security-facebook/blob/98637dbac6db0c3161a9d475109d24e6988223ab/src/main/groovy/com/the6hours/grails/springsecurity/facebook/FacebookAuthRedirectFilter.groovy#L12

martinduris commented 7 years ago

Confirming !

bluscreen commented 7 years ago

confirmed also. please just remove 3 preceding pkg paths 👍

martinduris commented 7 years ago

I dont know how "active" this plugin is ... if someone make pull request with fix, would we be able to release it ?

splix commented 7 years ago

@senty unfortunately I don't have time to maintain the plugin (and actually will be happy to pass it to someone who can do that), but I think I can find a time to release it if someone will make a pull request

martinduris commented 7 years ago

@splix hi i have create PR here https://github.com/splix/grails-spring-security-facebook/pull/99