Recorded future: Update - Fix a bug with scheduled pulling of events

rderkachrf commented 1 year ago

Please ensure your pull request (PR) adheres to the following guidelines:

Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist

Please check if your PR fulfills the following requirements:

[x] Testing of all the changes has been performed (for bug fixes / features)
[x] The readme.html has been reviewed and added / updated if needed (for bug fixes / features)
[x] Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
[x] Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
[x] Verify all checks are passing.
[x] Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
[x] Do NOT submit updates to dependencies unless it fixes an issue.
Pull Request Type

Please check the type of change your PR introduces:

[ ] New App
[x] Bugfix
[ ] Feature
[x] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation
[ ] Other (please describe):

Security Considerations (REQUIRED)

[ ] If you are exposing any endpoints using a REST handler, please document them in the readme.html.
[ ] If this is a new connector or you are adding new actions
- [ ] Please document in the readme.html all methods (eg, OAuth) used to authenticate with the service that the connector is integrating with.
- [ ] If any actions are unable to run on SOAR Cloud, please document this in the readme.html.
[ ] Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
[ ] Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through the Vault API.
[ ] Are you are marking code to be ignored by Semgrep with nosemgrep? If yes, please provide justification in an additional comment next to the ignored code.

Release Notes (REQUIRED)

This version fixes the error that occurs when use scheduled pulling of events.
Change the name of the app from "Recorded Future" to "Recorded Future For Splunk SOAR"

What is the current behavior? (OPTIONAL)

Describe the current behavior that you are modifying.

What is the new behavior? (OPTIONAL)

Describe the behavior or changes that are being added by this PR.

Other information (OPTIONAL)

Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

Pay close attention to (OPTIONAL)

Any specific code change or test case points which must be addressed/reviewed at the time of GA release.

Screenshots (if relevant)

Thanks for contributing!

splunk-soar-connectors-bot commented 1 year ago

Thank you for your submission! We have a total of 9 PRs open right now, and we are working hard on all of them! We will take a look as soon as we can.

splunk-soar-connectors-bot commented 1 year ago

@rderkachrf Static Tests results for commit 41772e1ffd0c3fff20f81a9e2f06db2e3c0e07f4 - https://drive.google.com/file/d/1nWJnLSYTsePJ7tg9DkZ0PddYq8BD6ZSq/view?usp=drivesdk

splunk-soar-connectors-bot commented 1 year ago

@rderkachrf Compile Tests results for commit 41772e1ffd0c3fff20f81a9e2f06db2e3c0e07f4 - https://drive.google.com/file/d/1iNaNKo_CXUqWf46yfPRXHvV327d0KhNC/view?usp=drivesdk

hardik-crest commented 1 year ago

Hello @rderkachrf , As the app already exists on the Splunk Base with the a unique name, is there any reason for changing the name of app ?

rderkachrf commented 1 year ago

Hi @hardik-crest Currently, there are three apps "Recorded Future App for Splunk", "Recorded Future Sandbox" and "Recorded Future". We want to rename this app to "Recorded Future App for Splunk SOAR" to follow the naming convention of our Splunk app. We also want to rename the sandbox app to "Recorded Future Sandbox for Splunk SOAR" in the future.

hardik-crest commented 1 year ago

Thanks @rderkachrf , We will make the required changes accordingly.

cc : @nastorSplunk

splunk-soar-connectors-bot commented 1 year ago

@rderkachrf Static Tests results for commit 41772e1ffd0c3fff20f81a9e2f06db2e3c0e07f4 - https://drive.google.com/file/d/1XhfHN2OhvF0II0RIUKR1BFAZ8NXaGPNY/view?usp=drivesdk

splunk-soar-connectors-bot commented 1 year ago

@hardik-crest Static Tests results for commit cc8865e18dfc14c1ef26e0731d793bc31c537e21 - https://drive.google.com/file/d/1Yswn8lUSrQ2QbON5xYhnkhzDzvbr-aas/view?usp=drivesdk

splunk-soar-connectors-bot commented 1 year ago

@hardik-crest Compile Tests results for commit cc8865e18dfc14c1ef26e0731d793bc31c537e21 - https://drive.google.com/file/d/1pmvks-vZibdwextNC5CPcQntNtmeIPU0/view?usp=drivesdk

splunk-soar-connectors-bot commented 1 year ago

@hardik-crest Static Tests results for commit 4c41dc840fd89033adb033636154e42f946d6cc1 - https://drive.google.com/file/d/1vmYO3tUSlLCSaz9Y4WAQlNgHjFyKX3mi/view?usp=drivesdk

splunk-soar-connectors-bot commented 1 year ago

@hardik-crest Compile Tests results for commit 4c41dc840fd89033adb033636154e42f946d6cc1 - https://drive.google.com/file/d/1qYoPJAfjHYrCZG-GMLvxCnXCvGN2f-kl/view?usp=drivesdk

splunk-soar-connectors-bot commented 1 year ago

@hardik-crest Static Tests results for commit a53c8b49122db5e694fe83abb71426ec880b269e - https://drive.google.com/file/d/1p7GaM_Vd--_6im3l-JM2ExBeJr7Z2xv-/view?usp=drivesdk

splunk-soar-connectors-bot commented 1 year ago

@hardik-crest Compile Tests results for commit a53c8b49122db5e694fe83abb71426ec880b269e - https://drive.google.com/file/d/1g5iomBhQ4SFU67vfYYWjMnnfw_ffhzX_/view?usp=drivesdk

splunk-soar-connectors-bot commented 1 year ago

@hardik-crest Compile Tests results for commit a53c8b49122db5e694fe83abb71426ec880b269e - https://drive.google.com/file/d/13MXbAL0oN6naIagLtnm0VK8zentjFU-V/view?usp=drivesdk

splunk-soar-connectors-bot commented 1 year ago

@hardik-crest Static Tests results for commit 1374b670934b0892451d74be9dd17f74e373eced - https://drive.google.com/file/d/19rfjZqtoVv5Ksm5XJ2nk-vhWRlcGnUZ-/view?usp=drivesdk

splunk-soar-connectors-bot commented 1 year ago

@hardik-crest Compile Tests results for commit 1374b670934b0892451d74be9dd17f74e373eced - https://drive.google.com/file/d/186Z-bjFKk17ss1hScLjXCFFmc2X_fnKw/view?usp=drivesdk

splunk-soar-connectors-bot commented 1 year ago

@hardik-crest Static Tests results for commit 2b7176fa2305b9458271c15d5d6464e47d21b8f8 - https://drive.google.com/file/d/1CRfTxB-q6i01wTE_g2pUwlhMAyzQtVem/view?usp=drivesdk

hardik-crest commented 1 year ago

Hello @rderkachrf , As this is a bug fix, according to standards changing the app version from 4.0.1 to 4.1.0

splunk-soar-connectors-bot commented 1 year ago

@hardik-crest Compile Tests results for commit 2b7176fa2305b9458271c15d5d6464e47d21b8f8 - https://drive.google.com/file/d/1LyH_5BPDmNRaFLYv7bFpwfv2Os61nJz7/view?usp=drivesdk

rderkachrf commented 1 year ago

Hello @rderkachrf , As this is a bug fix, according to standards changing the app version from 4.0.1 to 4.1.0

Hello @hardik-crest. Got it. Thanks.

splunk-soar-connectors-bot commented 1 year ago

@hardik-crest Static Tests results for commit e830e8918db7a79d8ed7982d846c389966c28054 - https://drive.google.com/file/d/1VTvHell9PizaiDg58nJ1dcG7jgYbqoBL/view?usp=drivesdk

splunk-soar-connectors-bot commented 1 year ago

@hardik-crest Compile Tests results for commit e830e8918db7a79d8ed7982d846c389966c28054 - https://drive.google.com/file/d/1UQPf5EHSpBkHqd2LlmJG2dVyZ5n4fnx1/view?usp=drivesdk

splunk-soar-connectors / recordedfuture