search

splunk / eventgen

Splunk Event Generator: Eventgen
Apache License 2.0
376 stars 180 forks source link

add throughput summary and fix timmer blocked by end=3 count=0 settings #346

Open Yangxulight opened 4 years ago

Yangxulight commented 4 years ago

Here is what I did in this PR:

  1. Add Throughput summary when we call "/status" from a controller. (eventgen_controller_api.py)
  2. When we have a sample with settings of "count=0, end=3", the timer for that sample will blocked and only log "There is no data to be generated in worker...". because the execution is always 0. We should increase the execution so that this sample timer can finished the job after 3 execution.
arctan5x commented 4 years ago

Would you add a functional test for throughput summary?

li-wu commented 4 years ago

Would you add a functional test for throughput summary?

+1. Especially for the end = 3 and count = 0 setting scenario. Thanks, Ryan.

Yangxulight commented 4 years ago

It seems that the CircleCI was blocked by my test code(ec9192c). Do you guys have some ideas about the reason?

li-wu commented 4 years ago

It seems that the CircleCI was blocked by my test code(ec9192c). Do you guys have some ideas about the reason?

Could you place the test logic in another test function since you need to set the conf and start eventgen and validate the logic?