splunk / splunk-sdk-python

Splunk Software Development Kit for Python
http://dev.splunk.com
Apache License 2.0
687 stars 369 forks source link

Preserve thirdparty cookies #463

Closed ashah-splunk closed 2 years ago

ashah-splunk commented 2 years ago
bendikro commented 2 years ago

Were the tests updated to ensure there won't be any regressions?

ashah-splunk commented 2 years ago

@bendikro yes tests were updated in PR #449 as part of the fix for issue #438. As we cannot have a setup with a middleware on the CI test execution we do not have tests for the exact scenario instead we have test cases where some cookie exists but not the Splunk Auth Cookie and authentication is carried out using username and password. Here Username/Password can be substituted by either Session key or bearer token.