fix: delete in binding.py now same as get/post

splunk / splunk-sdk-python

Splunk Software Development Kit for Python

http://dev.splunk.com

Apache License 2.0

687 stars 369 forks source link

fix: delete in binding.py now same as get/post #575

Open DanielPerezJensen opened 4 months ago

DanielPerezJensen commented 4 months ago

Currently you can not pass custom headers to delete, as they are overwritten with default self._auth_headers. Replaced that with all_headers as in get and put.

DanielPerezJensen commented 4 months ago

This change is required to leverage .delete using splunklib. Current work is blocked by this, as deletion is not possible without header authentication. Please have a look at this, or any other way we can expedite this.

DanielPerezJensen commented 4 months ago

Saw in another PR wanting to solve the same thing, to add a test case. Where would you suggest I do that? In which testing file is this functionality tested usually?