Do we need to send back unused ether back to you address?

sponnet / locals-faucetserver

a (testnet) Ether faucet with a React frontend and a REST API

MIT License

155 stars 71 forks source link

Do we need to send back unused ether back to you address? #4

Closed dananichev closed 6 years ago

dananichev commented 6 years ago

Hello!

We are using your faucet in tests. Simplified example:

generate first (1) keypair and address
ask faucet for ETH
transfer small amount of ETH to ERC20 token
generate second (2) keypair and address
transfer small amount of ERC20 from 1 to 2

In the end address 1 has >0.5 ETH left each time we run tests (manual or CI). And address 2 has small amount of ERC20 tokens. Usually it is considered good practice to return unused coins to faucet. Do we need to return them to you?

Thanks!

dananichev commented 6 years ago

Nvm, decided to slightly change logic of our tests. They will now use only one address and send small amount of ETH and ERC20 tokens.