search

spotify / dataenum

Algebraic data types in Java.
Apache License 2.0
166 stars 16 forks source link

Use java.util.Arrays for array fields #29

Closed pettermahlen closed 5 years ago

pettermahlen commented 5 years ago

Fixes #28.

Array fields aren't really ideal to use in Dataenum, because of mutability, but if you do, I guess the generated code should be better.

codecov[bot] commented 5 years ago

Codecov Report

Merging #29 into master will increase coverage by 0.45%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #29      +/-   ##
============================================
+ Coverage     93.95%   94.41%   +0.45%     
- Complexity      209      218       +9     
============================================
  Files            23       23              
  Lines           645      662      +17     
  Branches         93      100       +7     
============================================
+ Hits            606      625      +19     
  Misses           30       30              
+ Partials          9        7       -2
Impacted Files Coverage Δ Complexity Δ
...um/processor/generator/value/ValueTypeFactory.java 98.42% <100%> (+0.7%) 56 <1> (+7) :arrow_up:
.../spotify/dataenum/processor/DataEnumProcessor.java 95.45% <100%> (+2.59%) 19 <0> (+2) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6ef2125...3679452. Read the comment docs.