spree / deface

Rails plugin that allows you to customize ERB views in a Rails application without editing the underlying view.
MIT License
520 stars 127 forks source link

Problem with licensing - gem "colorize" uses GPLv2 license #153

Open jgracin opened 8 years ago

jgracin commented 8 years ago

Hello!

I can see that deface uses "colorize" as a dependency. However, "colorize" uses GPLv2 license, which seems to me affects all code which depends on deface, making deface's MIT license misleading.

In https://github.com/mattheworiordan/capybara-screenshot/issues/93, they resolved the same issue by replacing "colorize" with https://github.com/defunkt/colored. Could something like this be done in deface?

vizjerai commented 8 years ago

There is a pull request to fix this in #152

heroic commented 6 months ago

fixed with: https://github.com/spree/deface/pull/168