search

spring-attic / tut-react-and-spring-data-rest

React.js and Spring Data REST :: A tutorial based on the 5-part blog series by Greg Turnquist
https://spring.io/guides/tutorials/react-and-spring-data-rest
883 stars 1.58k forks source link

Fixes frontend-maven-plugin snippet in `basic` module. #130

Open UgmaDevelopment opened 3 years ago

UgmaDevelopment commented 3 years ago

It looks like, to maintain sanity, the configuration for the frontend-maven-plugin was defined in the root tutorial pom and the configuration is inherited by all the submodules, like basic.

The problem was that one following along with the project needs that configuration.

Now, we show the full configuration instead by including the frontend-maven-plugin configuration from the root POM instead of from basic's POM.

Should resolve some concerns described in issues #124, #128.

UgmaDevelopment commented 3 years ago

It makes sense why there's been some people confused about this plugin.

What they were seeing: image

What they needed to be seeing: image

UgmaDevelopment commented 3 years ago

Can you think of anything that would stop this PR from being merged?

mtravnicek commented 3 years ago

@gregturn Well this actually fixes nothing i dont even see any relevant file being commited... But what needs to be fixed so in basic and other modules will frontend:install-node-and-npm goal work in Idea is that in main pom.xml must nodeVersion and npmVersion tags be moved to upper plugin configuration section just where \<installDirectory>target\</installDirectory> resides. I dont get it why you didnt tested it, or does it work from plain mvn commandline? Anyway great tutorial but this is broken.

benhunter commented 2 years ago

Is this PR still being considered? It would be extremely helpful to update the Spring Guide: Accessing JPA Data with REST with this change. Thank you!

zlelik commented 11 months ago

This is still a problem in 2023 and the tutorial does not work :(

lions-dan commented 8 months ago

@UgmaDevelopment Thanks Ugma; this should have been Incorporated