search

spring-cloud / spring-cloud-bus

Spring Cloud event bus
http://cloud.spring.io/spring-cloud-bus/
Apache License 2.0
409 stars 242 forks source link

Pass BusProperties in order to get the most up to date bus id #219

Closed ryanjbaxter closed 4 years ago

ryanjbaxter commented 4 years ago

The bus id could change, for example in the case of a refresh event. When that happens beans that were passed the bus id may be out of sync if the busid property is not set because we use a random number.

ryanjbaxter commented 4 years ago

This could also be an issue in the 2.2.x branch but since it has not been reported and it would be a bit of ugly code to make it work without breaking constructors I decided to just put it in master. If we need to we can make the ugly changes in the 2.2.x branch.

ryanjbaxter commented 4 years ago

@spencergibb thoughts?

ryanjbaxter commented 4 years ago

Closing this as #220 seems to make this unnecessary