search

spring-cloud / spring-cloud-dataflow

A microservices-based Streaming and Batch data processing in Cloud Foundry and Kubernetes
https://dataflow.spring.io
Apache License 2.0
1.11k stars 581 forks source link

Investigate differences between uberjar created via scdf build and start.spring.io #1004

Closed markpollack closed 5 years ago

markpollack commented 7 years ago

For example, when data flow server local inherits from the dataflow parent pom we get

[DEBUG]             org.eclipse.aether:aether-transport-http:jar:1.0.2.v20150114:compile
[DEBUG]                org.apache.httpcomponents:httpclient:jar:4.5:compile (version managed from 4.2.6 by org.springframework.cloud:spring-cloud-consul-dependencies:1.1.1.RELEASE)

coming from spring-cloud camden bom

but if after changing data flow local server to inherti from the sprint boot parent pom, we get a different version 

[DEBUG]             org.eclipse.aether:aether-transport-http:jar:1.0.2.v20150114:compile
[DEBUG]                org.apache.httpcomponents:httpclient:jar:4.5.2:compile (version managed from 4.2.6 by org.springframework.boot:spring-boot-dependencies:1.4.1.RELEASE)

This means that the other projects in spring-cloud-dataflow that inherit from the data flow parent pom are getting slightly different versions. See the diff below.

However, adding spring-boot-dependency bom before the spring-cloud-dependency bom in the spirng-cloud-dataflow parent pom

            <dependency>
                <groupId>org.springframework.boot</groupId>
                <artifactId>spring-boot-dependencies</artifactId>
                <version>${spring-boot.version}</version>
                <type>pom</type>
                <scope>import</scope>
            </dependency>
            <dependency>
                <groupId>org.springframework.cloud</groupId>
                <artifactId>spring-cloud-dependencies</artifactId>
                <version>${spring-cloud.version}</version>
                <type>pom</type>
                <scope>import</scope>
            </dependency>

brings the versions in sync (I only checked httpclient version).

Should we add this to the parent pom?

Here is a full diff

--- (before)
+++ (after)
@@ -1,4 +1,3 @@
-accessors-smart-1.1.jar
 aether-api-1.0.2.v20150114.jar
 aether-connector-basic-1.0.2.v20150114.jar
 aether-impl-1.0.2.v20150114.jar
@@ -7,10 +6,8 @@
 aether-transport-http-1.0.2.v20150114.jar
 aether-util-1.0.2.v20150114.jar
 aopalliance-1.0.jar
-asm-5.0.3.jar
 aspectjrt-1.8.9.jar
 aspectjweaver-1.8.9.jar
-assertj-core-2.5.0.jar
 bcpkix-jdk15on-1.55.jar
 bcprov-jdk15on-1.55.jar
 classmate-1.3.1.jar
@@ -26,12 +23,10 @@
 commons-pool2-2.4.2.jar
 freemarker-2.3.25-incubating.jar
 h2-1.4.192.jar
-hamcrest-core-1.3.jar
-hamcrest-library-1.3.jar
 hibernate-validator-5.2.4.Final.jar
 hsqldb-2.3.3.jar
-httpclient-4.5.jar
-httpcore-4.4.1.jar
+httpclient-4.5.2.jar
+httpcore-4.4.5.jar
 jackson-annotations-2.8.3.jar
 jackson-core-2.8.3.jar
 jackson-core-asl-1.9.13.jar
@@ -42,13 +37,9 @@
 jcl-over-slf4j-1.7.21.jar
 jedis-2.8.1.jar
 jettison-1.2.jar
-joda-time-2.7.jar
+joda-time-2.9.4.jar
 json-20140107.jar
-json-path-2.2.0.jar
-json-smart-2.2.1.jar
-jsonassert-1.2.3.jar
 jul-to-slf4j-1.7.21.jar
-junit-4.12.jar
 log4j-over-slf4j-1.7.21.jar
 logback-classic-1.1.7.jar
 logback-core-1.1.7.jar
@@ -57,8 +48,6 @@
 maven-model-3.2.1.jar
 maven-model-builder-3.2.1.jar
 maven-repository-metadata-3.2.1.jar
-mockito-core-1.10.19.jar
-objenesis-2.1.jar
 plexus-component-annotations-1.5.5.jar
 plexus-interpolation-1.19.jar
 plexus-utils-3.0.17.jar
@@ -84,11 +73,8 @@
 spring-boot-starter-jdbc-1.4.1.RELEASE.jar
 spring-boot-starter-logging-1.4.1.RELEASE.jar
 spring-boot-starter-security-1.4.1.RELEASE.jar
-spring-boot-starter-test-1.4.1.RELEASE.jar
 spring-boot-starter-tomcat-1.4.1.RELEASE.jar
 spring-boot-starter-web-1.4.1.RELEASE.jar
-spring-boot-test-1.4.1.RELEASE.jar
-spring-boot-test-autoconfigure-1.4.1.RELEASE.jar
 spring-cloud-commons-1.1.5.RELEASE.jar
 spring-cloud-config-client-1.2.1.RELEASE.jar
 spring-cloud-context-1.1.5.RELEASE.jar
@@ -133,7 +119,6 @@
 spring-security-rsa-1.0.3.RELEASE.jar
 spring-security-web-4.1.3.RELEASE.jar
 spring-session-1.2.2.RELEASE.jar
-spring-test-4.3.3.RELEASE.jar
 spring-tx-4.3.3.RELEASE.jar
 spring-web-4.3.3.RELEASE.jar
 spring-webmvc-4.3.3.RELEASE.jar
sabbyanandan commented 5 years ago

We don't have SCDF in Spring Initializr and that's not the promoted model (for SCDF) anyway, so closing this as invalid.