search

spring-projects-experimental / spring-grpc

88 stars 19 forks source link

Add autoconfig for reflection service and friends #26

Closed dsyer closed 1 week ago

dsyer commented 1 month ago

Probably all gated behind a boolean enabled flag. The configuration is easy, it's just deciding what to do by default, e.g. in the existing sample

@Bean
public BindableService serverReflection() {
    return ProtoReflectionService.newInstance();
}
CyberZujo commented 4 weeks ago

I'd like to help here. Can you assign it please. Thank you!

CyberZujo commented 2 weeks ago

https://github.com/spring-projects-experimental/spring-grpc/pull/45 @onobc Can you please have a look and provide a feedback if I'm on the right track. Thank you. Kind regards, Haris.

onobc commented 2 weeks ago

Hi @CyberZujo , I will take a look sometime today. Thank you.

CyberZujo commented 1 week ago

Everything good with this one? @dsyer