search

spring-projects-experimental / spring-grpc

88 stars 19 forks source link

typo: correct org.springframework.ai to org.springframework.grpc #38

Closed linux-china closed 3 weeks ago

onobc commented 3 weeks ago

Hi @linux-china I just realized this PR is the same as the one that I just merged https://github.com/spring-projects-experimental/spring-grpc/pull/39. You made the fix first and I should have merged yours but I just noticed as I working the PRs top-down. Thank you for the fix.

onobc commented 3 weeks ago

Closing via https://github.com/spring-projects-experimental/spring-grpc/pull/39

lbkulinski commented 3 weeks ago

@onobc I did see this PR, but it didn't fix all occurrences of the group ID typo from what I could see. I figured it would just be easier to open a separate PR to fix both occurrences

onobc commented 3 weeks ago

I just want you to know that we appreciate your contributions @lbkulinski and it was my bad as your PR was actually the first one submitted. It happens sometimes though 😄.

Thank you.