Closed cagliostro92 closed 3 weeks ago
@cagliostro92 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
@cagliostro92 Thank you for signing the Contributor License Agreement!
Hi @bclozel, I would like to bring to your attention that the offending assertion is still present and invoked in ResourceHttpRequestHandler and PathResourceLookupFunction. Let me know how you prefer handling such cases. PS: I've rebased my branch onto your main a few minutes ago, so if you have already downloaded it, please drop it.
Thanks for the proposal, but I'm declining this one in favor of https://github.com/spring-projects/spring-framework/issues/33815#issuecomment-2449473711
Re-opening as per discussion under #33826.
Thanks for the PR, and I will apply equivalent changes, but I need to start in 6.1.x where the code is different, and then forward merge to main.
As already stressed by @philwebb in #33815 and by my colleague @milazzo-g, the brand new assertion about the required trailing slash can lead to important breaking changes in both custom project and libraries. As mentioned by the author in #33712:
It seems to be clear that this constraint was intended to avoid unexpected behaviour, but the framework can still be accountable for adding the trailing slash without breaking other projects.
closes: #33815