search

springernature / boomcatch

A standalone, node.js-based beacon receiver for boomerang.
GNU General Public License v3.0
110 stars 33 forks source link

fix rt query parameter and rt new data format #95

Open itsMattShull opened 6 years ago

itsMattShull commented 6 years ago

To fix https://github.com/springernature/boomcatch/issues/49 and https://github.com/springernature/boomcatch/issues/83

itsMattShull commented 6 years ago

@josebolos it appears Travis failed because no Node environment was set. Is this something I can fix on my end?

josebolos commented 6 years ago

Hi @derekshull

Thanks for contributing to boomcatch, this is great!

The reason the tests in Travis are failing is because the changes in this PR break some of the unit tests. You can see the details of the test run here: https://travis-ci.org/springernature/boomcatch/jobs/400192639

Your PR tries to address two different problems - we usually ask people to submit different PRs for different issues, as it makes it easier to revert changes in case something goes wrong.

Do you have the time and energy for submitting separate PRs with their respective unit tests? It will be greatly appreciated.

Thanks again!