search

springweblobby / swl-website

Weblobby site component
10 stars 11 forks source link

remove ping for ZKLS #113

Closed sprunk closed 7 years ago

sprunk commented 7 years ago

Ping was removed https://github.com/ZeroK-RTS/Zero-K-Infrastructure/commit/3afebe6cba65cee7db784e7c4f51e21607c3cae8

This causes uber spam (see #zkerror):

[294 xxx.xxx.xxx.xxx:63660 CarRepairer] error processing line Ping {} : System.Exception: Invalid json type PlasmaShared.CommandJsonSerializer : Ping at PlasmaShared.CommandJsonSerializer.DeserializeLine(String line) at ZkLobbyServer.ClientConnection.d__9.MoveNext()

db81 commented 7 years ago

Ideally we'd want to come up with some no-op for ZKLS that will give us a response to use as the pong. (That, or I finally release a new version of the backend that reports broken socket to js).

DeinFreund commented 7 years ago

MM queue size updates are sent regularly, not exactly pongs but maybe those could be used as workaround.

db81 commented 7 years ago

Merged for now without using queue size message as ping, because even @Licho1 started to complain about #zkerror spam.