search

sprintly / sprintly-kanban

A Kanban Board for Sprintly
https://kanban.sprint.ly
ISC License
494 stars 82 forks source link

9282 - Wire in Filters #1

Closed wookiehangover closed 9 years ago

wookiehangover commented 9 years ago

What does it do?

Adds the filters UI and data management.

Where should the reviewer start?

The FiltersStore is a good place to start. It establishes a FiltersCollection that's used to manage the presentational data for filters (available options, state.) There are also refactorings to ProductStore to support merging and updating Filters as managed by collections in sprintly-data.

On the UI side, the FiltersToolbar component is created by the Items "View-Controller." All other Filter components are children of this component.

Background context

This is still WIP because there are more tests incoming.

There's also likely to be a follow up PR to implement a more Flux-y pattern for reconciling dependencies between the FiltersStore and ProductStore https://docs.google.com/document/d/1zUSyoRTvRBleuU2FTvnnRqhaS-tcM1ACcabqahiOkMk/edit#

Screenshots:

screen shot 2015-03-16 at 3 54 02 pm screen shot 2015-03-16 at 3 54 13 pm

justinabrahms commented 9 years ago

Looks good. Would be nice to have @florapdx look, as I am a little lost on the react specifics.

florapdx commented 9 years ago

Will definitely take a look this evening :)

florapdx commented 9 years ago

Couple small comments to address then :+1: