Closed wookiehangover closed 9 years ago
Code looks good to me. Haven't downloaded it to test, but should have time this afternoon.
This didn't actually work for me. Screenshot below shows receiving a pusher update for deleting the item in the backlog, but it's not removed.
Hrm, that seems weird... The deletes work just fine for me:
@justinabrahms thinking about it more, if you're seeing that logging (and you didn't put it in yourself,) your build must not have picked up the changes in this branch.
Yeah, shoot, I don't know what's going on, but it's not working for me either. At first it may have been the same issue that you pointed out to Justin (ie, that he wasn't running the latest code), so I ran $ npm run build and restarted the server. Though I'm now seeing the latest code in the sources tab, I'm still not seeing updates to 5columns:
Thank @justinabrahms and @florapdx for pulling this down and testing it out. I did a clean checkout (with a clean npm install
, too) to try and rule out anything "special" that was happening on my local setup that was leading to me getting different results w/r/t item deletes. Unfortunately I wasn't able to reproduce what either of you were seeing.
Taking advantage of Wercker's one click deploys to staging, I deployed this branch to see if it worked there. And survey says: this looks good on staging:
Still not sure what's going on with your local dev environments for 5 columns :sob: but it's on staging now if you want to see it in action: https://sprintly-manifold.herokuapp.com/
What does it do?
Fixes a few issues with Pusher:
Where should the reviewer start?
Pusher handling code in
app/stores/product-store.js
and testsHow should it be manually tested?
When viewing the kanban board, add and delete items in the main site. You should see them be created and removed in the kanban board.
GIF?