sprintly / sprintly-kanban

A Kanban Board for Sprintly
https://kanban.sprint.ly
ISC License
494 stars 82 forks source link

9730 column totals #32

Closed mikekauffman closed 8 years ago

mikekauffman commented 9 years ago

\ please see comment at bottom of the thread for updates :) -- (fw) **

What's this PR do?

Displays total counts of items and their accumulative points by status in the item-column headers.

Any background context or notes you want to provide?

Which code should the reviewer start with?

app/views/pages/items.js and app/actions/velocity-actions.js

How is this feature tested (either manually or automatically)?

API is tested. Functionality/styling of the counts can be seen on the main view.

What are the relevant tickets (please include link(s))?

Delivers #9730 https://sprint.ly/product/1/item/9730

screen shot 2015-06-10 at 4 23 34 pm

What gif best describes this PR or how it makes you feel?

Definition of Done:

wookiehangover commented 9 years ago

@mikekauffman can you square this up with the styling changes that have landed in master?

mikekauffman commented 9 years ago

@wookiehangover should be good to go. Let me know if anything else is needed.

wookiehangover commented 9 years ago

@mikekauffman can you merge/rebase master into this?

mikekauffman commented 9 years ago

@wookiehangover pulled in master

florapdx commented 9 years ago

This is ready for review :)

Velocity-actions.js was starting to look like an action-store hybrid so I pulled all of the data-processing out into the product-store, leaving the action creator interface a little cleaner. I thought about creating a velocity store (and think this might be something we should think about for the future as we continue to beef up our support for agile workflows), but decoupling velocity from product-store internals is a bit more involved than time allows atm.

CI failure was instant, and I assume related to the recent Wercker changes that we're dealing with elsewhere.

khalsah commented 9 years ago

@florapdx CI should work again if you merge in the latest master.

florapdx commented 9 years ago

Cool, thanks @khalsah!